update no longer fail when deprecated plugins exist
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tedraykov <[email protected]>
|
If I have a plugin that is not valid for whatever reason (for example, here I made it up) I still get the message: We should probably make that message a little more generic like "We were unable to find {plugin-name} to update" so it's not confusing. |
brent-hoover
requested changes
Oct 31, 2022
vanpho93
reviewed
Dec 28, 2022
| .map(({ name, version }) => { | ||
| const remoteDependency = remoteDependencies[name]; | ||
| if (remoteDependency === undefined) { | ||
| Logger.warn(`Plugin ${name} used by the local project has been officially deprecated.`); |
There was a problem hiding this comment.
Just kike Brent suggested
Suggested change
| Logger.warn(`Plugin ${name} used by the local project has been officially deprecated.`); | |
| Logger.warn(`We were unable to find ${name} to update`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156
Before comparing the local plugin version with the remote plugin version, check if the remote plugin still exists. In not, display a warning that the local project is using a deprecated plugin.
Test steps:
@reactioncommerce/api-plugin-payments-stripeplugin which has been deprecatedreaction updatecommandupdatecommand will succeed nonetheless.Signed-off-by: tedraykov [email protected]